[gstreamer-bugs] [Bug 317438] [speed] fix 0.9 port

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=317438
 GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Additional Comments From Tim-Philipp Müller  2005-10-10 23:21 -------
Looks fine, please commit to CVS, if there's anything else that can always be
fixed later.

Here's two more issues:

  - at the end of the chain function you should probably replace

        gst_pad_push (filter->srcpad, out_buf);
        gst_buffer_unref (in_buf);
        return GST_FLOW_OK;

            with

        result = gst_pad_push (filter->srcpad, out_buf);
        gst_buffer_unref (in_buf);
        return result;


  - generally there aren't any locks anywhere when speed->foo
    members are accessed (e.g. in the set/get_property functions,
    in the chain function and in the query+event functions). These
    can be accessed concurrently from multiple threads though, so
    you should guard against by surrounding those critical sections
    with GST_LOCK (speed) and GST_UNLOCK (speed).

 Cheers
  -Tim


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.