[gstreamer-bugs] [Bug 319731] SimpleBlock support for Matroska muxer and demuxer

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=319731
 GStreamer | gst-plugins-good | Ver: 0.9.x

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53873|                            |commented-on
             Status|                            |
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From Tim-Philipp Müller  2005-10-28 08:52 -------
Patch looks very good to me.

Just one question:

In matroska_mux_write_data() you add this:

+  /* write the block, for matroska v2 use SimpleBlock if possible
+   * one slice (*breath*).
+   * FIXME: lacing, etc. */

What's the implication of the 'FIXME: lacing etc.'? How important is that for a
functional muxer and valid output? (And what does the '*breath*' mean? Like
'*gasp*'?)


I also wondered about this:

  *(guint16 *) & GST_BUFFER_DATA (hdr)[1] = foo;

Aren't there alignment issues with that on some platforms? Maybe it would be
better to use GST_WRITE_UINT16_LE, GST_WRITE_UINT16_BE and friends here. (I know
this was in the original code, I'm just wondering).

 Cheers
  -Tim


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.