[gstreamer-bugs] [Bug 337386] New: Pipeline bus is not initially flushing

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=337386
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: Pipeline bus is not initially flushing
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: msmith at fluendo.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


When a pipeline bus is created, it isn't initially flushing.
However, if we change the pipeline from NULL to READY then back to NULL, it
will (by default) be flushing.

I'm fairly sure we should be setting this bus to flushing on creation (we
already set it to non-flushing when we go to READY).

This causes leaks in tests/check/gst/gstghostpad.c (revealed when running under
valgrind), as we add things to a pipeline when in NULL, receive a clock-provide
message, and this message is never flushed (or read). 

The clock-provides message is itself bogus in this test (I'll file another bug
for that), but if the added element was a real clock provider, this would be
triggerable anyway.

I'll attach a patch that implements the behaviour I suggested, but I'm not sure
how correct it is. Feedback appreciated. Note that this will cause any
application listening for clock-provide messages on the bus with a pipeline in
NULL to break. However, this is a pretty obscure case, and I don't know of any
application that listens for clock-provide messages in any state.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.