[gstreamer-bugs] [Bug 337388] New: Bogus clock-provide messages being created

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=337388
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: Bogus clock-provide messages being created
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: msmith at fluendo.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


See bug #337386 for some context.

In the testcase that was causing this problem, we do the following:
  1) Create pipeline.
  2) Create bin.
  3) Create fakesink
  4) Put fakesink in bin
  5) Put bin in pipeline

At step 5, we get a bogus clock-provide message being created (bogus because
fakesink is NOT a clock provider).

The reason for this is that, when we add something to a bin (in this case
adding a bin to a pipeline), we create the clock-provide message if 
gst_element_provides_clock() returns TRUE for the element being added.

For fakesink, this correctly returns false (so when we add the fakesink to the
bin, we don't create a message).

However, for the bin, it returns true: we return true in
gst_element_provides_clock() if the element has a provide_clock vfunc. For a
bin, we always have this vfunc, regardless of whether any of our children
provide clocks. This is wrong.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.