[gstreamer-bugs] [Bug 337749] totem (gstreamer) crashes when playing an avi file

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=337749
 GStreamer | gst-plugins-good | Ver: 0.10.2


Ryan Lortie (desrt) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|totem-gstreamer-            |gstreamer-
                   |maint at gnome.bugs            |bugs at lists.sourceforge.net
             Status|UNCONFIRMED                 |NEW
          Component|GStreamer backend           |gst-plugins-good
     Ever Confirmed|0                           |1
         OS/Version|Linux                       |All
           Priority|Normal                      |High
            Product|totem                       |GStreamer
          QAContact|totem-gstreamer-            |gstreamer-
                   |maint at gnome.bugs            |bugs at lists.sourceforge.net
   Target Milestone|---                         |HEAD
            Version|unspecified                 |0.10.2




------- Comment #4 from Ryan Lortie (desrt)  2006-04-08 23:24 UTC -------
gst_riff_parse_chunk returns NULL in the last (pass-by-reference) argument in
the vent that the chunk has a size of zero.

sub here is the chunk.

        stream->name = g_new (gchar, GST_BUFFER_SIZE (sub) + 1);

GST_BUFFER_SIZE casts to GstObject and looks at ->size.  crash because sub is
NULL.

3 easy ways to fix this crasher:

1:
GST_BUFFER_SIZE should return 0 if its argument is NULL.
GST_BUFFER_DATA should return NULL if its argument is NULL.

2:
alternatively the avidemux code should check for NULL and behave accordingly.

3:
alternatively the riff_parse_chunk code should allocate an empty chunk instead
of returning NULL.


reassigning to gst, confirming and raising priority since this is such a
trivial fix.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.