[gstreamer-bugs] [Bug 338715] [shout2send] fix crash on error and tags received before connection is made

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=338715
 GStreamer | gst-plugins-good | Ver: 0.10.2


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63648|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|Patch on shout2 plugin      |[shout2send] fix crash on
                   |                            |error and tags received
                   |                            |before connection is made
   Target Milestone|HEAD                        |0.10.3




------- Comment #4 from Tim-Philipp Müller  2006-04-17 19:59 UTC -------
Should be fixed in CVS now, thanks for the patch.

2006-04-17  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Philippe Valembois

        * ext/shout2/gstshout2.c: (gst_shout2send_init),
        (gst_shout2send_set_metadata), (gst_shout2send_event),
        (gst_shout2send_render), (gst_shout2send_change_state):
        * ext/shout2/gstshout2.h:
          Handle tags being received before the connection to
          the server is established properly (see #338636).

2006-04-17  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/shout2/gstshout2.c: (gst_shout2send_render):
          Don't crash in case the connection to the server fails:
          don't set pointer to NULL by assigning FALSE; error out
          properly by using GST_ELEMENT_ERROR and returning
          GST_FLOW_ERROR (fixes #338636). Lastly, free connection
          before resetting the pointer.

FWIW, this element seriously needs a rewrite.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.