[gstreamer-bugs] [Bug 337625] [patch] Streaming support for wavparse

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=337625
 GStreamer | gst-plugins-good | Ver: 0.10.2





------- Comment #8 from Tim-Philipp Müller  2006-04-26 23:09 UTC -------
Minor nitpick:

+  if (gst_pad_is_linked (wav->srcpad)) {
+    if ((res = gst_pad_push (wav->srcpad, buf)) != GST_FLOW_OK)
+      goto push_error;
+  } else {
+    gst_buffer_unref (buf);
+    goto not_linked;
+  }

that's unnecessary, if not racy. There's no need to check if the pad is linked
in advance, GST_FLOW_NOT_LINKED should just be handled like any other
non-FLOW_OK flow value.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.