[gstreamer-bugs] [Bug 350296] [udpsrc] add property to remove extra headers from buffers

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=350296
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70398|none                        |commented-on
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
            Summary|[udpsrc] remove udp header  |[udpsrc] add property to
                   |from GstBuffer              |remove extra headers from
                   |                            |buffers




------- Comment #2 from Tim-Philipp Müller  2006-08-08 08:02 UTC -------
Thanks for the patch!

Some comments:

(Note: I don't know much about how things are supposed to work on the RTP side
of things in GStreamer, I'm just commenting on the code)

 - "skip-header" sounds a bit generic, and it would be good IMHO if it was
   possible to know from the property name and the property description
   what this property actually does, without reading the code. I don't
   think that's quite the case yet ("skip a header, 0 = default" - so
   there isn't even an indication that this is in bytes or a size or
   length or anything).

 - please don't use temp->size directly, use GST_BUFFER_SIZE (temp)

 - you should check for udpsrc->skip_header >= buffer_size before
   trying to make a subbuffer (not really sure what to do in that
   case though, maybe just drop the buffer with a GST_WARNING
   or so?)

 - you should special-case the normal case of udpsrc->skip_header == 0
   where creating a sub buffer can be avoided altogether


Someone else will need to comment on whether this is useful to have in the
first place though.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.