[gstreamer-bugs] [Bug 350935] API: add GST_TAG_EXTENDED_COMMENT

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Sun Aug 13 12:18:25 PDT 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=350935
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Comment #6 from Tim-Philipp Müller  2006-08-13 19:18 UTC -------
> What would happen with multiple comment tags in the case of retagging a file
> that has multiple comments?  We would want to preserve them all separately (as
> we do now, I think).

That change wouldn't really have any effect on retagging (unless the tag
writing element is buggy).


> I'm not sure what you mean by "leaving it to the application"?  Can you give an
> example of how this would in (say) rhythmbox?

Applications who want to get _all_ comments would need to do

  for (i = 0; i < gst_tag_list_get_tag_size (taglist, GST_TAG_COMMENT); ++i) {
    gchar *nth_comment;

    nth_comment = gst_tag_list_get_string_index (taglist, GST_TAG_COMMENT, i,
&nth_comment);
  }

since

  gst_tag_list_get_string (taglist, GST_TAG_COMMENT, &str);

would now be equivalent to

  gst_tag_list_get_string (taglist, GST_TAG_COMMENT, 0, &str);


I don't know where the problem is with that rhythmbox retagging bug, but feel
free to point me or others to some code on IRC so we can take a look. It's
either an extraction problem (not doing the above), or a tag merging problem.
The id3v2mux log should tell you. Feel free to CC me on the bug if you want me
to comment on anything related there.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list