[gstreamer-bugs] [Bug 351768] New: Unwanted concurent buffer modifications

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=351768
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: Unwanted concurent buffer modifications
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: michal.benes at itonis.tv
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


I have a pipeline
      +-- retimestamp -- audioconvert
tee --|
      +-- retimestamp -- audioconvert
My retimestamp plugin only calls gst_buffer_make_metadata_writable and changes
timestamp
The problem is that gst_buffer_make_metadata_writable is implemented as
gst_buffer_create_sub internally. The created subbuffer has only one reference
and hence it is writable (is it possible that it is writable even if the parent
has READONLY flag set?!).

Now, both the duplicated buffers created by tee are writable and point to the
same memory, this is a clear problem when audioconvert chooses to the the
converion in place.

I think, that the correct solution would be to mark all subbuffers as READONLY.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.