[gstreamer-bugs] [Bug 352476] [wavpack] documentation, unit tests, memleak fix

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=352476
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71425|none                        |committed
               Flag|                            |
  Attachment #71426|none                        |committed
               Flag|                            |
  Attachment #71427|none                        |rejected
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.4




------- Comment #8 from Tim-Philipp Müller  2006-08-23 10:32 UTC -------
Thanks, docs and tests committed:

 2006-08-23  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge <slomo at circular-chaos.org>

        * tests/check/Makefile.am:
        * tests/check/elements/.cvsignore:
        * tests/check/elements/wavpackdec.c: (setup_wavpackdec),
        (cleanup_wavpackdec), (GST_START_TEST), (wavpackdec_suite), (main):
        * tests/check/elements/wavpackenc.c: (setup_wavpackenc),
        (cleanup_wavpackenc), (GST_START_TEST), (wavpackenc_suite), (main):
        * tests/check/elements/wavpackparse.c: (wavpackparse_found_pad),
        (setup_wavpackparse), (cleanup_wavpackparse), (GST_START_TEST),
        (wavpackparse_suite), (main):
          Add unit tests for wavpack elements (#352476).

 2006-08-23  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge <slomo at circular-chaos.org>

        * docs/plugins/Makefile.am:
        * docs/plugins/gst-plugins-bad-plugins-docs.sgml:
        * docs/plugins/gst-plugins-bad-plugins-sections.txt:
        * docs/plugins/gst-plugins-bad-plugins.hierarchy:
        * docs/plugins/inspect/plugin-wavpack.xml:
        * ext/wavpack/gstwavpackdec.c:
        * ext/wavpack/gstwavpackdec.h:
        * ext/wavpack/gstwavpackenc.c:
        * ext/wavpack/gstwavpackenc.h:
        * ext/wavpack/gstwavpackparse.c:
        * ext/wavpack/gstwavpackparse.h:
          Add docs for wavpack elements (#352476).


About that memleak fix ... the code is wrong of course, but I'm not sure the
fix is right. We need to send a newsegment event on both pads before sending
any data, so the event bit needs to be done in both cases.

 2006-08-23  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block):
          Fix mem leak, send newsegment event on correction pad
          as well (#352476).

        * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init):
          Restore original author (on Sebastian's request).

        * tests/check/Makefile.am:
        * tests/check/gst-plugins-bad.supp:
          Add (so far empty) suppression file for -bad. Remove
          wavpackenc test from VALGRIND_TO_FIX now that the leak
          is fixed.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.