[gstreamer-bugs] [Bug 358841] [dv1394src] should have property probe

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=358841

  GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #6 from Tim-Philipp Müller  2006-12-09 19:39 UTC -------
> I have two questions on the current code of dv1394src :
> (1) why are strings freed in _dispose? They should be in _finalize.

For all practical purposes, it doesn't really matter (as long as you keep in
mind that dispose may be called multiple times). It's probably just that
someone copy'n'pasted it from elsewhere. Feel free to fix and send a patch.


> (2) how come rom1394_free_directory is never called although
> rom1394_get_directory is?

(Disclaimer: I'm not familiar with the code or the library) It might just be an
oversight/leak. You can verify this by running an application (or
gst-launch-0.10 pipeline containing the element and triggering the code path in
question) in valgrind with --leak-check=yes and see if it reports this as leak,
for example. Please fix and send a patch if you find there's a leak :)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email