[gstreamer-bugs] [Bug 385527] New: oggmux sometimes gets DELTA flag on output wrong near start

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=385527

  GStreamer | gst-plugins-base | Ver: HEAD CVS

           Summary: oggmux sometimes gets DELTA flag on output wrong near
                    start
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: msmith at fluendo.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


If oggmux is muxing audio and video, and it chooses to output audio first
(presumably because it has earlier timestamps), it gets the delta flags on the
output wrong until the first video keyframe is seen.

This is because the audio doesn't have the delta flag set ever, and
oggmux->delta_pad doesn't get set until oggmux decides to process video. So, it
outputs audio pages with the delta flag not set, even though it should be set.

This could be fixed by moving the delta_pad decision into the collectpads
callback - looking at a buffer on every pad - rather than doing it only on the
pad it's currently processing.

Also see https://core.fluendo.com/flumotion/trac/ticket/526


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email