[gstreamer-bugs] [Bug 380342] Totem does not play mp3 files when lyrics are present

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Sat Dec 16 06:05:01 PST 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=380342

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|totem-gstreamer-            |gstreamer-
                   |maint at gnome.bugs            |bugs at lists.sourceforge.net
             Status|NEW                         |RESOLVED
          Component|GStreamer backend           |gst-plugins-base
            Product|totem                       |GStreamer
          QAContact|totem-gstreamer-            |gstreamer-
                   |maint at gnome.bugs            |bugs at lists.sourceforge.net
         Resolution|                            |FIXED
   Target Milestone|---                         |0.10.12
            Version|2.16.x                      |HEAD CVS




------- Comment #5 from Tim-Philipp Müller  2006-12-16 14:03 UTC -------
Okay, guess we need to make decodebin/playbin a bit smarter then:

Fixed for playbin+decodebin (default), still needs fixing for
playbin+decodebin2 (future default):

 2006-12-16  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/playback/gstdecodebin.c: (type_found):
          Special-case the text/plain media type: we only want to recognise it
          as a 'raw' decoded media type if it comes from a demuxer or subtitle
          parser, but not if the entire stream is of text/plain type. If the
          entire stream is text/plain, we should just error out.

          This fixes playback of audio files with lyrics in totem. Totem can't
          distinguish between text files and subtitle files and passes any
          .txt file with the same basename as the main file to playbin as
          suburi, and playbin will then throw a 'subtitle found, but no video
          stream' error, which isn't entirely helpful. See #380342.

          Also, with this change we'll show a slightly more correct error
          message in case totem passes a playlist file to us (although a
          custom error message wording instead of the default text would
          probably not be a bad idea either).

          Same problem also needs to be fixed for playbin+decodebin2.

        * tests/check/Makefile.am:
        * tests/check/elements/decodebin.c: (src_handoff_cb),
        (decodebin_new_decoded_pad_cb), (GST_START_TEST),
        (decodebin_suite):
          Add simple unit test for decodebin for the above.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email




More information about the Gstreamer-bugs mailing list