[gstreamer-bugs] [Bug 303167] Add bzip2 support

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Sat Feb 4 10:25:46 PST 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=303167
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Andy Wingo changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58705|none                        |needs-work
               Flag|                            |




------- Comment #8 from Andy Wingo  2006-02-04 18:25 UTC -------
regarding attachment #58705 -- please add a changelog entry as well, that makes
sure you get in the release notes.

regarding attachment #58706 -- Always pay attention to the return value of
gst_pad_push. Use gst_pad_alloc_buffer instead of gst_buffer_new_and_alloc, and
pay attention to its return value. Use GST_BOILERPLATE instead of manually
defining a get_type function. 

Constructs like these:

  GstBz2dec *b = GST_BZ2DEC (gst_pad_get_parent (pad));
  GstPad *src = gst_element_get_pad (GST_ELEMENT (b), "src");

return new references; you will need to unref b and src before the end of the
function. This applies to both the decoder, and two places in the encoder.

Otherwise these are looking good.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list