[gstreamer-bugs] [Bug 332277] New: filesrc element seek does not correct read position

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=332277
 GStreamer | gstreamer (core) | Ver: 0.10.2

           Summary: filesrc element seek does not correct read position
           Product: GStreamer
           Version: 0.10.2
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: renchi at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


In the filesrc element, if the mmap code path is not used, i.e
gst_file_src_create_read routine is called, setting of a offset different than
the current read_position will cause a seek. But the read_position is not
updated after the seek. This will cause some demuxers to fail on an
architecture which does not support mmap.

Currently:

  if (src->read_position != offset) {
    off_t res;

    res = lseek (src->fd, offset, SEEK_SET);
    if (res < 0 || res != offset)
      goto seek_failed;
  }

Should be:
  if (src->read_position != offset) {
    off_t res;

    res = lseek (src->fd, offset, SEEK_SET);
    if (res < 0 || res != offset)
      goto seek_failed;

    src->read_position = offset;
  }


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.