[gstreamer-bugs] [Bug 330996] basesrc emits EOS unconditionally when going to READY

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=330996
 GStreamer | gstreamer (core) | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59278|none                        |committed
               Flag|                            |




------- Comment #10 from Tim-Philipp Müller  2006-02-23 18:08 UTC -------
Patch committed, gstutils test case reverted, and new tests for GstBaseSrc EOS
behaviour added:

2006-02-23  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/Makefile.am:
        * tests/check/libs/basesrc.c: (eos_event_counter),
        (basesrc_eos_events_pull), (basesrc_eos_events_push),
        (basesrc_eos_events_push_live_op), (basesrc_eos_events_pull_live_op),
        (gst_basesrc_suite), (main):
          ... and add some tests for the base source EOS stuff.

2006-02-23  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/gst/gstutils.c: (test_buffer_probe_n_times):
          Test case originally showed the problem fixed below,
          but was then amended. Add checks back at the place
          where they used to be.

2006-02-23  Tim-Philipp Müller  <tim at centricular dot net>

        * libs/gst/base/gstbasesrc.c: (gst_base_src_class_init),
        (gst_base_src_init), (gst_base_src_loop),
        (gst_base_src_activate_push), (gst_base_src_activate_pull),
        (gst_base_src_change_state):
        * libs/gst/base/gstbasesrc.h:
          Don't unconditionally send EOS when going from PAUSED to
          READY state, esp. make sure we don't send two EOS events
          in some cases (e.g. one when reaching EOS and one when
          going from PAUSED to READY). Also, we don't want to send
          EOS events when operating in pull mode. However, we do
          want to send an EOS event when shutting down a live
          source explicitly, for example (fixes #330996).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.