[gstreamer-bugs] [Bug 325504] [flacdec] gst_flac_dec_convert_src [mis]uses g_assert

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=325504
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56662|none                        |needs-work
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
            Summary|flacdec                     |[flacdec]
                   |gst_flac_dec_convert_src    |gst_flac_dec_convert_src
                   |[mis]uses g_assert          |[mis]uses g_assert




------- Comment #2 from Tim-Philipp Müller  2006-01-02 13:16 UTC -------
Yes, you are right. Those assertions in _convert_src() shouldn't really be
there, and it should just return FALSE instead.

However, your patch doesn't seem to do that, it just removes the assertions
there ... :)

The assertion in the chain function that checks that width is a multiple of 8
should probably stay.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.