[gstreamer-bugs] [Bug 325504] [flacdec] gst_flac_dec_convert_src [mis]uses g_assert

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=325504
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56675|none                        |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.1




------- Comment #5 from Tim-Philipp Müller  2006-01-02 19:40 UTC -------
Apologies, you are perfectly right. I didn't actually look at the code, I just
had a quick look at the patch. Didn't expect those checks down there :)

Fixed in CVS, thanks for the patch:


2006-01-02  Alessandro Decina  <alessandro at nnva dot org>

        Reviewed by: Tim-Philipp Müller  <tim at centricular dot net>

        * ext/flac/gstflacdec.c: (gst_flac_dec_write),
        (gst_flac_dec_convert_src), (gst_flac_dec_src_query),
        (gst_flac_dec_change_state):
          Don't g_assert() where we should just return FALSE; remove
          unnecessary g_assert(); initialize some fields properly in
          state change function (fixes #325504). Also, use
          GST_DEBUG_OBJECT in two more places.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.