[gstreamer-bugs] [Bug 326734] [mad] Add 24-bit output support

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=326734
 GStreamer | gst-plugins-ugly | Ver: HEAD CVS





------- Comment #12 from Radoslaw Szkodzinski  2006-01-14 22:14 UTC -------
>Patches look ok from a brief read, except this bit looks strange:
-  bytes_per_sample = MAD_NCHANNELS (&mad->frame.header) << 1;
+  bytes_per_sample = MAD_NCHANNELS (&mad->frame.header) * 32;

32 should be a 4. It was initially 3, meaning 24 bit samples, but I of course
outsmarted myself.

Of course, it could also be a bit shift by 2, which is much less readable and
not faster at all. (when using any optimising compiler)

As for permission: We apparently don't need any. 
If it would be needed, then previous code was also taken from minimad.c from
libmad, so there's no change. Also LGPL.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.