[gstreamer-bugs] [Bug 323693] [PATCH] [lame] accept track-count tag

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=323693
 GStreamer | gst-plugins-ugly | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56618|none                        |commented-on
               Flag|                            |




------- Comment #5 from Tim-Philipp Müller  2006-01-23 16:42 UTC -------
Patch is generally okay, but:

 * gst_lame_id3tag_set_track() has 'static char str[6]', which is
   very easy to fix in this context by just removing the static
   keyword

 * as far as I can tell the code only works if the TRACK_COUNT
   field comes before the TRACK_NUMBER field in the tag list.

Not really sure how to best get around the second issue. Maybe we should just
special-case track count and track number and avoid rewriting all the other
stuff.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.