[gstreamer-bugs] [Bug 323693] [PATCH] [lame] accept track-count tag

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=323693
 GStreamer | gst-plugins-ugly | Ver: HEAD CVS





------- Comment #6 from malsyned at uofr.net  2006-01-24 02:41 UTC -------
> gst_lame_id3tag_set_track() has 'static char str[6]'
Woops.  Oversight.  Absolutely right about removing the 'static' keyword.

> only works if the TRACK_COUNT field comes before the TRACK_NUMBER
I don't see why that would be.  a TRACK_NUMBER field will trigger a call to
gst_lame_set_track, which just sticks the track number in the TagInfo struct
it's passed and returns.  Likewise for TRACK_COUNT.  Then, after all of the
functions in tag_matches[] have been called and all available track info has
been collected, a call to gst_lame_id3tag_set_track (as opposed to
gst_lame_set_track --  I probably could have picked better names) actually puts
together the proper argument to id3tag_set_track and passes it in.  The order
of the calls to the other two functions shouldn't matter.  Am I missing
something?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.