[gstreamer-bugs] [Bug 337026] oggmux doesn't set EOS properly

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=337026
 GStreamer | gst-plugins-base | Ver: HEAD CVS


James "Doc" Livingston changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doclivingston at gmail.com




------- Comment #12 from James "Doc" Livingston  2006-07-07 15:05 UTC -------
(In reply to comment #11)
> gst_ogg_mux_queue_pads (GstOggMux * ogg_
>        GstBuffer *buf;
>        gboolean incaps;
> 
> +      if (pad->removed) {
> +        ogg_stream_clear (&oggpad->stream);
>                             ^^^^^^
> should be &pad->stream?

Looks like it.

> A brief test confirms that:
> 1. soundjuicer works with this.
> 2. the Ogg/Vorbis produced is a conforming stream.
> 3. Decoding to wav will cmp with a rip to flac round-
>    tripped through oggenc and oggdec at the same q setting.
> 
> Bizarrely the decoded test file is slightly shorter if eos
> is not set. May have some time this weekend, any suggested
> tests?

Probably the more important things to test would be more exotic things:
1) ogg theora - creating and remuxing
2) something to do with streaming
3) any other weird stuff


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.