[gstreamer-bugs] [Bug 347091] converting vorbis comments to GstTagLists is lossy

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347091
 GStreamer | gst-plugins-base | Ver: HEAD CVS





------- Comment #1 from James "Doc" Livingston  2006-07-10 13:45 UTC -------
Created an attachment (id=68715)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=68715&action=view)
possible patch

This is a possible patch to do this (it works for me).

It works by registering a new tag GST_TAG_VORBIS_UNKNOWN which is used when
GStreamer encounters an unknown tag, with the tag data set to be the entire
"key=value" string. I haven't exported it because it's only used inside the
gst_vorbis_tag_add and gst_tag_to_vorbis_comments function (and indirectly by
gst_tag_list_{to,from}_vorbiscomment_buffer).

If this looks like an acceptable approach, I'll tidy it up. I'm not sure
whether  the gst_tag_to_vorbis_tag and gst_tag_from_vorbis_tag should, or even
could correctly, deal with the _UNKNOWN tag. If it's thought applications
should be able to use this to write arbitrary vorbis comments, then the tag
could be made public.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.