[gstreamer-bugs] [Bug 347293] New: GstValueList comparison is flawed

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347293
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: GstValueList comparison is flawed
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: thaytan at mad.scientist.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Looking at the code in gstvalue.c, it seems that GstValueLists are considered
equal if
a) they are the same length
b) All items in list A exist in list B.

This is faulty if list A contains duplicates.

A better algorithm might be:

1. If lists are not the same length, return UNORDERED
2. Copy list B -> B'
3. For each item I in list A:
   3a. If I does not exist in B', return UNORDERED
   3b. Remove I from B'
4. If B' is not empty, return UNORDERED
5. Return EQUAL


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.