[gstreamer-bugs] [Bug 347443] [wavpack] port parser/decoder to official API and random cleanup

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347443
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68918|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.4




------- Comment #5 from Tim-Philipp Müller  2006-07-18 14:12 UTC -------
Committed with a whole bunch of changes:

 2006-07-18  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge <slomo at circular-chaos.org>

        * configure.ac:
          Check for wavpack version and define WAVPACK_OLD_API if
          necessary.

        * ext/wavpack/Makefile.am:
        * ext/wavpack/gstwavpackcommon.c: (gst_wavpack_read_header),
        (gst_wavpack_read_metadata):
        * ext/wavpack/gstwavpackcommon.h:
        * ext/wavpack/gstwavpackdec.c: (gst_wavpack_dec_base_init),
        (gst_wavpack_dec_class_init), (gst_wavpack_dec_init),
        (gst_wavpack_dec_finalize), (gst_wavpack_dec_format_samples),
        (gst_wavpack_dec_clip_outgoing_buffer), (gst_wavpack_dec_chain),
        (gst_wavpack_dec_sink_event), (gst_wavpack_dec_change_state),
        (gst_wavpack_dec_request_new_pad), (gst_wavpack_dec_plugin_init):
        * ext/wavpack/gstwavpackdec.h:
        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_class_init),
        (gst_wavpack_enc_init), (gst_wavpack_enc_finalize),
        (gst_wavpack_enc_set_wp_config):
        * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init),
        (gst_wavpack_parse_finalize), (gst_wavpack_parse_class_init),
        (gst_wavpack_parse_index_get_entry_from_sample),
        (gst_wavpack_parse_scan_to_find_sample),
        (gst_wavpack_parse_handle_seek_event),
        (gst_wavpack_parse_create_src_pad):
        * ext/wavpack/gstwavpackstreamreader.c:
        * ext/wavpack/gstwavpackstreamreader.h:
          Port to new/official wavpack API, don't use API that was exported
          in wavpack header files and in the lib but meant to be private, at
          least not for recent wavpack versions; misc. 'cleanups' (#347443).

Next time it would be nice if you could do separate patches for library API
updates, additional stuff like clipping and cleanups/whitespace fixes/randomly
moving functions around - it's a lot more work reviewing mega-patches like this
if everything is mixed together :)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.