[gstreamer-bugs] [Bug 347935] [nsf] warning when building RPM

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347935
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|Warning when building RPM   |[nsf] warning when building
                   |                            |RPM
   Target Milestone|HEAD                        |0.10.4




------- Comment #1 from Tim-Philipp Müller  2006-07-19 11:44 UTC -------
Should be:

--- gst/nsf/nsf.c       18 Jul 2006 09:36:46 -0000      1.2
+++ gst/nsf/nsf.c       19 Jul 2006 11:41:36 -0000
@@ -476,7 +476,7 @@ nsf_load (char *filename, void *source,
   /* seek to end of header, read in data */
   if (NULL == source) {
     fseek (fp, NSF_HEADER_SIZE, SEEK_SET);
-    if (fread (temp_nsf->data, temp_nsf->length, 1, fp) < 0)
+    if (fread (temp_nsf->data, temp_nsf->length, 1, fp) != 1)
       log_printf ("error reading end of header\n");

     fclose (fp);

fixed now (hopefully):

  2006-07-19  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/nsf/nsf.c: (nsf_load):
          Really fix compilation. Apparently it's not enough to
          just check the return value for errors, but we need to
          check for short reads as well (now if only we handled
          them too ...). Fixes #347935.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.