[gstreamer-bugs] [Bug 347898] [id3v2mux] write GST_TAG_ENCODER and GST_TAG_ENCODER_VERSION

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347898
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69100|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[id3v2mux] [PATCH] plugin   |[id3v2mux] write
                   |doesn't write tag           |GST_TAG_ENCODER and
                   |corresponding to            |GST_TAG_ENCODER_VERSION
                   |GST_TAG_ENCODER{_VERSION}   |
   Target Milestone|HEAD                        |0.10.4




------- Comment #5 from Tim-Philipp Müller  2006-07-19 12:24 UTC -------
Ah, thanks for checking, TSSE seems indeed more appropriate to me.

Committed your patch with the following modifications:

  - if we have ENCODER_VERSION but no ENCODER, just skip it

  - don't add "(id3v2mux foobar)" bit to tag string; I think the
    element should write the tag unmodified as it is passed to it
    (makes retagging/rewriting less messy as well). Still, it might
    make sense to add this kind of information somewhere at some
    point (maybe into a custom TXXX frame or comment?)


  2006-07-19  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Alex Lancaster <alexl at users sourceforge net>

        * ext/taglib/gstid3v2mux.cc:
          Write GST_TAG_ENCODER and GST_TAG_ENCODER_VERSION as
          ID3v2 TSSE frames (#347898).



Also updated -base so that id3demux reads the tag:

 2006-07-19  Tim-Philipp Müller  <tim at centricular dot net>

       * gst-libs/gst/tag/gstid3tag.c:
         Add TSSE <=> GST_TAG_ENCODER mapping (see #347898).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.