[gstreamer-bugs] [Bug 349068] multipart demuxer improvements

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Fri Jul 28 09:16:45 PDT 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=349068
 GStreamer | gst-plugins-good | Ver: 0.10.x


Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim at fluendo.com
  Attachment #69813|none                        |committed
               Flag|                            |
         AssignedTo|gstreamer-                  |wim at fluendo.com
                   |bugs at lists.sourceforge.net  |
   Target Milestone|HEAD                        |0.10.4




------- Comment #2 from Wim Taymans  2006-07-28 16:16 UTC -------
Thanks! Comitting already because it's much better than what there currently
is. 

I think it does the wrong thing if the stream starts in the middle of a data
packet. It will first scan for a \n, which is the end of the data packet and
will then fail because there is no boundary marker in front of it. Maybe
scanning for [r]\n--<marker>[\r]\n would work better.


        Patch by: Sjoerd Simons <sjoerd at luon dot net>

        * gst/multipart/multipartdemux.c: (gst_multipart_demux_base_init),
        (gst_multipart_demux_class_init), (gst_multipart_demux_init),
        (gst_multipart_demux_finalize), (get_line_end),
        (multipart_parse_header), (multipart_find_boundary),
        (gst_multipart_demux_chain), (gst_multipart_demux_change_state),
        (gst_multipart_set_property), (gst_multipart_get_property):
        Uses GstAdapter instead of own buffering.
        Actually parses the mime-type correctly (In tests the mime-type was
        always "" with the old version).
        Uses the Content-length header if available to speed up things.
        Reliably autoscans the boundary name by default.
        Almost fixes #349068.

        * gst/multipart/multipartmux.c: (gst_multipart_mux_collected):
        Don't start the stream with a \n.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list