[gstreamer-bugs] [Bug 343988] data protocol needs extending to handle events better

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343988
 GStreamer | gstreamer (core) | Ver: 0.10.6


Michael Smith changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msmith at fluendo.com




------- Comment #2 from Michael Smith  2006-06-06 09:33 UTC -------
"This data protocol assumes an underlying lossless connection, such as" -
standard terminology is "a reliable connection-oriented transport". 

Can we call the new protocol version "0.3" or "0.10", reserving "1.0" for the
version of DP corresponding to a hypothetical future gstreamer 1.0?

/* we only copy KEY_UNIT,DELTA_UNIT and IN_CAPS flags */ - why only these? The
only buffer flag that looks like it shouldn't be copied to me is readonly,
since we always make a writable buffer on the other side.

This isn't new in your patch, but is there a way to check whether debugging is
on? The stuff in gst_dp_dump_byte_array() is quite expensive even when
debugging is off, and should be skipped in that case.

+  /* FIXME: GST_IS_CAPS doesn't work
+     g_return_val_if_fail (GST_IS_CAPS (caps), FALSE); */ - please find out
why, fix, and reinstate this check.

In gst_dp_packet_from_caps_any, avoid calling strlen multiple times. Fairly
trivial, but it's good practice. Using a NULL terminator here is bad protocol
design, perhaps you can fix this for the new version? 

Why does GstDPPacketizer have major, minor members, rather than a single
GstDPVersion member? Do you want ABI padding in this struct?

Basic idea looks solid.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.