[gstreamer-bugs] [Bug 343131] [wavpack] add wavpack encoder

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=343131
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66616|none                        |committed
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|[wavpack][PATCH] new        |[wavpack] add wavpack
                   |wavpackenc element          |encoder
   Target Milestone|HEAD                        |0.10.4




------- Comment #16 from Tim-Philipp Müller  2006-06-10 15:42 UTC -------
Works fine for me, let's do the additional fixes separately - I'm sure there's
always something else to add/fix ;)

I'm not entirely sure about how the "bitrate" property works - I think it's a
bit awkward. What about doing separate properties for the bits-per-sample and
the bitrate stuff and using 0 for lossless?

Also, I think most other encoders specify the bitrate in bits per second
instead of kilobits per second, maybe that should be changed too (I think
that's what we're going to standardise on in 0.11, see bug #337409).



2006-06-10  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge  <mail at slomosnail de>

        * ext/wavpack/Makefile.am:
        * ext/wavpack/gstwavpack.c: (plugin_init):
        * ext/wavpack/gstwavpackcommon.h:
        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_mode_get_type),
        (gst_wavpack_enc_correction_mode_get_type),
        (gst_wavpack_enc_joint_stereo_mode_get_type),
        (gst_wavpack_enc_base_init), (gst_wavpack_enc_class_init),
        (gst_wavpack_enc_init), (gst_wavpack_enc_dispose),
        (gst_wavpack_enc_sink_set_caps), (gst_wavpack_enc_set_wp_config),
        (gst_wavpack_enc_format_samples), (gst_wavpack_enc_push_block),
        (gst_wavpack_enc_chain), (gst_wavpack_enc_rewrite_first_block),
        (gst_wavpack_enc_sink_event), (gst_wavpack_enc_change_state),
        (gst_wavpack_enc_set_property), (gst_wavpack_enc_get_property),
        (gst_wavpack_enc_plugin_init):
        * ext/wavpack/gstwavpackenc.h:
        * ext/wavpack/md5.c:
        * ext/wavpack/md5.h:
          Add wavpack encoder element (#343131).

Minor changes made:
 - md5.[ch]: include "_stdint.h" and use glib defines for endianness; include
   string.h for memcpy() instead of memory.h
 - wavpack.c: use GST_ macros for origin etc. in plugin definition (that was
   already borked before though)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.