[gstreamer-bugs] [Bug 344642] New: tools/gst-inspect.c does not compile if --disable-nls is used

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=344642
 GStreamer | gstreamer (core) | Ver: 0.10.7

           Summary: tools/gst-inspect.c does not compile if --disable-nls is
                    used
           Product: GStreamer
           Version: 0.10.7
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: pkj at axis.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Please describe the problem:
We do not have gettext support in our product, and thus we configure gstreamer
using the --disable-nls option.  However, with 0.10.7 and 0.10.8 the
compilation of tools/gst-inspect.h fails.  This is due to the unconditional
inclusion of libintl.h and the use of ngettext().

The correct solution is to include gst/gettext.h rather than libintl.h.  This
is done through gst/gst-i18n-app.h, but it is only done when ENABLE_NLS is
defined.  This is wrong IMHO, and gettext.h should be included unconditionally
since it provides fallback macros in case NLS is disabled.

The attached patch will make the inclusion of gettext.h unconditional in
gst/gst-i18n-app.h and gst/gst-i18n-lib.h, and it will remove the inclusion of
libintl.h in tools/gst-inspect.c.


Steps to reproduce:
Configure using --disable-nls and rebuild.

Actual results:
The compilation fails.

Expected results:
The compilation to suceed.

Does this happen every time?
Yes.

Other information:


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.