[gstreamer-bugs] [Bug 344667] [siddec] sounds very broken

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=344667
 GStreamer | gst-plugins-ugly | Ver: 0.10.2


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|libgstsid.so sounds very    |[siddec] sounds very broken
                   |broken                      |




------- Comment #1 from Tim-Philipp Müller  2006-06-12 14:59 UTC -------
In response to https://bugzilla.livna.org/show_bug.cgi?id=912#c2 :

> * There are several mistakes in the code. The official IANA MIME type
>   for SID files is 'audio/prs.sid'  not 'audio/x-sid'.
>   libgsttypefindfunctions.so for gst-typefind also knows about that
>   wrong MIME type for SID files. As both need a correction, this
>   cannot be done in this package.

This doesn't really need fixing (nor can it be fixed in a stable series
for API/ABI compatibility reasons), since audio/x-sid is not a MIME type
in this context, it's a 'GStreamer media type', which may or may
not correspond to the official MIME type :)


> * It doesn't become clear who the author of the plugin is. Compare
>   header with inline author information.

The inline author information tends to be more correct, the header is
probably a boilerplate copyright header from the plugin skeleton
generator in this case. In any case, patches or bugs should generally
go into bugzilla and not be mailed to the author (since the people
actively working on things change a lot, or e-mail addresses are out
of date etc.).


> * Several engine paramters are customised in a weird way. Memory
>   mode MPU_BANK_SWITCHING should be the safe default. Enabling
>   'forceSongSpeed' mode is clearly wrong. Stereo is well, eh, an
>   inappropriate default for music which consists of mostly three
>   voices. Default filter parameters should not be touched unless
>   the developer knows what he's doing. It's not necessary. The
>   code should read the default configuration and modify only
>   where necessary.

Could you provide us with a sample file or point us towards a sample
file that demonstrates the problem by any chance?

Regarding the patch: if we get the default configuration from the lib,
we should probably also use the retrieved default values as the default
values in the GObject properties registration in class_init, no?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.