[gstreamer-bugs] [Bug 345288] [PATCH] udp for Windows

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=345288
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67711|none                        |commented-on
               Flag|                            |
  Attachment #67715|none                        |commented-on
               Flag|                            |




------- Comment #5 from Tim-Philipp Müller  2006-06-21 19:26 UTC -------
> +#ifdef G_OS_UNIX
>        if ((ret =
>                setsockopt (src->sock, IPPROTO_IP, IP_ADD_MEMBERSHIP,
>                    &src->multi_addr, sizeof (src->multi_addr))) < 0)
> +#endif
> +#ifdef G_OS_WIN32
> +      if ((ret = setsockopt (src->sock, 
> +                             IPPROTO_IP, 
> +                             IP_ADD_MEMBERSHIP,
> +                             (char *)&src->multi_addr, 
> +                             sizeof (src->multi_addr))) < 0)
> +#endif

This just adds a cast, wouldn't that be more elegant to do with a #define?

Also, please use ... #else ... in the code where it makes sense.



> +AM_CONDITIONAL(HAVE_WINSOCK2_H, test "x$HAVE_WINSOCK2_H" = "xyes")

Don't think you need that (you aren't using that anywhere in Makefile.am, are
you?)


>  if test "x$HAVE_SYS_SOCKET_H" != "xyes"; then
> -  GST_PLUGINS_SELECTED=`echo $GST_PLUGINS_SELECTED | $SED -e s/udp//`
> -  GST_PLUGINS_SELECTED=`echo $GST_PLUGINS_SELECTED | $SED -e s/rtsp//`
> -  GST_PLUGINS_NO="\tudp\n$GST_PLUGINS_NO"
> -  GST_PLUGINS_NO="\trtsp\n$GST_PLUGINS_NO"
> +  if test "x$HAVE_WINSOCK2_H" != "xyes"; then
> +    GST_PLUGINS_SELECTED=`echo $GST_PLUGINS_SELECTED | $SED -e s/udp//`
> +    GST_PLUGINS_SELECTED=`echo $GST_PLUGINS_SELECTED | $SED -e s/rtsp//`
> +    GST_PLUGINS_NO="\tudp\n$GST_PLUGINS_NO"
> +    GST_PLUGINS_NO="\trtsp\n$GST_PLUGINS_NO"
> +  fi
> +fi

This disables compilation of udp and rtsp under *nix completely, doesn't it?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.