[gstreamer-bugs] [Bug 345679] New: fix to avoid goom core dumping

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=345679
 GStreamer | gst-plugins-good | Ver: HEAD CVS

           Summary: fix to avoid goom core dumping
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: opensolaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: brian.cameron at sun.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: 2.15/2.16
   GNOME milestone: Unspecified


I ntoice that on Solaris, goom core dumps.  It dies in getPixelRGB_ on this
line

   299    c->b = *(unsigned char *) (tmp8 = (unsigned char *) (buffer + x));

Because x has an extremely large value.  The call is happening here in the
function zoomFilterFastRGB:

   556      getPixelRGB_ (pix1, pos10[position], &col1, goomdata->resolx,
   557          goomdata->resoly);

Note that x in getPixelRGB_ corresponds to pos10[position].  Running in a
debugger, I notice that zoomFilterFastRGB is not initializing the pos10 array
the first time it is being called.

The attached patch causes goom to always initialize the array the first time it
is called (using a static boolean to keep track of the fact it has been called
the first time).  This seems to fix the goom core dumping problem on Solaris.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.