[gstreamer-bugs] [Bug 345713] New: ximagesrc uses XFixesCursorImage incorrectly and will segfault

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=345713
 GStreamer | gst-plugins-good | Ver: HEAD CVS

           Summary: ximagesrc uses XFixesCursorImage incorrectly and will
                    segfault
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tgoyen at swri.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The lines below are wrong:

cx = ximagesrc->cursor_image->x - ximagesrc->cursor_image->xhot;
cy = ximagesrc->cursor_image->y - ximagesrc->cursor_image->yhot;

xhot and yhot give the active hotspot of the cursor and in no way relate to
where the cursor image should be placed on the ximage. An easy crash for this
situation can be given by capturing with the default mouse in the upper left
corner. Its x, y is 0,0 and hot x,y is (1,1) which makes cx,cy (-1, -1) and
will imediately segfault any application.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.