[gstreamer-bugs] [Bug 333501] [patch] taglib element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=333501
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60788|none                        |commented-on
               Flag|                            |




------- Comment #15 from Tim-Philipp Müller  2006-03-06 20:46 UTC -------
Looks excellent. Some more minor nitpicks that I missed the first time, then I
think you're ready to go and can commit this to gst-plugins-bad:

 - the class name is GstTagLibMux, so functions should be called
   gst_tag_lib_mux_*() whenever possible

 - the debug category variable should probably have a prefix/suffix,
   just 'debug' isn't good even if it's static

 - some of the GST_DEBUG/etc. statements have newline characters at the end
   of the string, those aren't needed and should probably be removed.

 - lines should be commented out with /* ... */, as // doesn't work with some
   C compilers (like Sun's Forte).

 - in the sink event function, NEWSEGMENT part, at the beginning there's
   a gst_pad_push_event(); result = TRUE; that you forgot to convert

 - in the sink event function, 'default' case, it should be:
     result = gst_pad_event_default (pad, event);

As test pipeline

 % gst-launch-0.10 filesrc location=foo.ogg ! oggdemux ! vorbisdec !
audioconvert ! lame ! tagid3v2mux ! filesink location=foo.mp3

works quite well,

 % gst-launch-0.10 playbin uri=file://path/to/foo.mp3 -t

displays all the tags correctly :)

(Now to try with some proper UTF8 strings ...)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.