[gstreamer-bugs] [Bug 332598] port modplug to 0.10

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Wed Mar 8 04:46:06 PST 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=332598
 GStreamer | gst-plugins-bad | Ver: HEAD CVS


Christophe Fergeau changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |teuf at gnome.org
            Summary|[modplug] port to 0.10      |port modplug to 0.10
                   |[PATCH]                     |




------- Comment #2 from Christophe Fergeau  2006-03-08 12:46 UTC -------
Here are a few (tiny) nitpicks after a quick glance through it (based on the
comments __tim made on the code of a plugin I worked on ;)
* in gst_modplug_class_init you can get rid of the parent_class setting,
GST_BOILERPLATE does it for you
* in the same function, you should use GST_DEBUG_FUNCPTR when setting up
virtual function pointers (set_property, get_property, ...)
* in  gst_modplug_src_event, in EVENT_SEEK when you don't get a GST_FORMAT_TIME
query, I think you are leaking 'event'
* in gst_modplug_src_event, I'd set the var 'res' to the result of
gst_pad_push_event when possible

There may be more fundamental issues in your code, but my experience with gst
is pretty limited, so I can only make some not that useful comments ;)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list