[gstreamer-bugs] [Bug 333657] Replacing icy demuxing in gnomevfssrc

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=333657
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60794|none                        |commented-on
               Flag|                            |
  Attachment #61920|none                        |commented-on
               Flag|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #9 from Tim-Philipp Müller  2006-03-27 18:03 UTC -------
I like this approach, it's much cleaner than doing all this inside gnomevfssrc
IMHO.


Two minor issues with the typefind patch:
 - the int argument before the caps in the g_signal_emit() should
   be a typefind probability like GST_TYPE_FIND_MAXIMUM, not a size
 - we should probably set typefind->caps to the caps from the buffer
   (or alternatively change the
      gst_buffer_set_caps (store, typefind->caps)
   to 
      gst_buffer_set_caps (store, GST_BUFFER_CAPS (buffer));
   This only triggers in the extremely unlikely case that upstream
   sends a very small/too small to typefind first buffer without
   caps and then a second one with caps, so it's not that important
   I guess.

other than that I think the typefind bit should go in, I've wanted to add
something like that a while ago as well, but then forgot.


icydemux looks good to me as well, haven't tried it yet though. One thing I've
noticed though: can icecast streams ever contain ID3v2 tags in front of the
actual stream data? if yes, we probably need to think about that a bit more,
because
 - id3demux looks at buffer offsets in push mode IIRC (can be changed though)
 - id3demux can only parse one ID3v2 tag per stream at the moment (can ID3v2
   tags be embedded as additional metadata in icecast streams?)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.