[gstreamer-bugs] [Bug 340027] [patch] wavparse fails for several files

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Tue May 16 11:57:27 PDT 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=340027
 GStreamer | gst-plugins-good | Ver: HEAD CVS


Michael Smith changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msmith at fluendo.com




------- Comment #8 from Michael Smith  2006-05-16 18:57 UTC -------
C++ comments.
No docs on what wav->fact is; this is totally obscure!
Why not add fact parsing to gst-libs/gst/riff/? That would make more sense to
me.

I can't see where GST_RIFF_TAG_fact is defined at all?

Rather than the hack to set ->bps = 1, why not just allow bps == 0, and not use
it in any of the places where it's currently used? I can't imagine this is
answering queries sensibly at the moment.

The pad_unlinked stuff doesn't look right? You should just return appropriate
flow returns when you try to push things on that pad if neccesary.

This seems to confuse width with block alignment, which is admittedly a
confusing bit of handling wav.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the Gstreamer-bugs mailing list