[gstreamer-bugs] [Bug 339918] GstTagSetter merge-mode description unclear, and implementations inconsistent

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=339918
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Comment #12 from James "Doc" Livingston  2006-05-19 10:02 UTC -------
(In reply to comment #11)
>  (a) breakage in practice here (ie. happening with rhythmbox
>      as it is usually compiled/shipped by default), or
> 
>  (b) breakage in corner cases (ie. someone compiled rhythmbox
>      himself with the still experimental --enable-foobar option), or
> 
>  (c) mostly principle?

It only affects RB 0.9.4 (earlier versions didn't support tag-writing with
0.10) with --enable-tag-writing passed to configure (it is off by default);
although I think a reasonable number of people compile with that option (such
as seb128's 0.9.4.1 packages in his personal/non-official repo).

That said, the only effect is that it won't actually use the new tags when
rewriting - so it won't destroy files or anything. last time I checked, several
other music players operated like this all the time, changing their db but not
the files themselves.


> Does the code in rhythmbox explicitly set the merge mode of id3mux to something
> (REPLACE) that is documented - and was already documented back then - as doing
> the exact opposite of what rhythmbox wants to do, with the documentation of
> gst_tag_setter_set_merge_mode() explicitly describing KEEP mode to be what
> rhythmbox wants to do?

That's exactly what happens. Whoever originally wrote it must have had it not
working, throught that they maybe mis-understood the docs, and tried REPLACE
(which then worked).


> Is there a released version of rhythmbox yet that uses id3v2mux? (viewcvs
> didn't seem to feature anything id3v2mux-related)
> 
> Would it help to keep the old broken semantics for "id3mux" and only change it
> for id3v2mux?


id3v2mux is the one that only got added recently, right? We don't use that yet
(although I'll rememeber to do that once we have this issue sorted out).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.