[gstreamer-bugs] [Bug 358999] [PATCH] [GstPad] Flushing on blocked pads not handled correctly.

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=358999

  GStreamer | gstreamer (core) | Ver: HEAD CVS


Wim Taymans changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim at fluendo.com




------- Comment #2 from Wim Taymans  2006-10-02 14:05 UTC -------
The BLOCKING flag is only cleared when a flush arrives, it should also be
cleared when _set_blocked (pad, FALSE) is called.

Maybe this:

handle_pad_block:
      BLOCKING = TRUE;
      BLOCK_WAIT()
      if (FLUSHING)
        goto flushing;
      BLOCKING = FALSE;

event:
   FLUSH_START:
     FLUSHING = TRUE;
     BLOCK_SIGNAL;

   FLUSH_STOP
     FLUSHING = FALSE;     
     BLOCKING = FALSE;

so that unlocks triggered by flushes don't unset the blocking flag but normal
unblocks do.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email