[gstreamer-bugs] [Bug 335635] Add an Ogg/Vorbis retagging element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=335635

  GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73634|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|Need an OGG retagging       |Add an Ogg/Vorbis retagging
                   |element                     |element
   Target Milestone|HEAD                        |0.10.11




------- Comment #31 from Tim-Philipp Müller  2006-10-03 11:57 UTC -------
Thanks for the patch, committed to CVS:

 2006-10-03  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: James "Doc" Livingston <doclivingston at gmail com>

        * ext/vorbis/Makefile.am:
        * ext/vorbis/vorbis.c: (plugin_init):
        * ext/vorbis/vorbisparse.c: (gst_vorbis_parse_class_init),
        (vorbis_parse_parse_packet), (vorbis_parse_chain):
        * ext/vorbis/vorbisparse.h:
        * ext/vorbis/vorbistag.c: (gst_vorbis_tag_base_init),
        (gst_vorbis_tag_class_init), (gst_vorbis_tag_init),
        (gst_vorbis_tag_parse_packet):
        * ext/vorbis/vorbistag.h:
          Add new vorbistag element which derives from vorbisparse
          and is essentially the same as well, only that it implements
          the GstTagSetter interface and can modify the stream's
          vorbiscomment on the fly (#335635).

        * tests/check/Makefile.am:
        * tests/check/elements/.cvsignore:
        * tests/check/elements/vorbistag.c: (setup_vorbistag),
        (cleanup_vorbistag), (buffer_probe), (start_pipeline),
        (get_buffer), (stop_pipeline), (_create_codebook_header_buffer),
        (_create_audio_buffer), (GST_START_TEST), (vorbistag_suite):
          Add unit test for new vorbistag element.

with some minor changes: two fixes in the gobject macros, one in the
boilerplate macro (we derive from GstVorbisParse, not GstElement), and I added
a ::parse_packet vfunc to vorbis parse so we don't have to do the whole
save-the-old-chain-function business.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email