[gstreamer-bugs] [Bug 338818] [PLUGIN-MOVE] v4l2src from bad to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=338818

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Thomas Vander Stichele changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thomas at apestaart.org




------- Comment #27 from Thomas Vander Stichele  2006-10-03 14:11 UTC -------
I still see some obvious problems with the error stuff.

Here's an example:
fmt_failed:
  {
    GST_ELEMENT_ERROR (v4l2src, RESOURCE, SETTINGS,
        (_("Failed to set pixelformat to %s @ %dx%d for device %s: %s."),
            fmt->description, *width, *height, v4l2src->v4l2object->videodev),
        GST_ERROR_SYSTEM);
    return FALSE;
  }
pixfmt_failed:
  {
    GST_ELEMENT_ERROR (v4l2src, RESOURCE, SETTINGS,
        (_("Failed to set pixelformat to %s @ %dx%d for device %s: %s."),
            fmt->description, *width, *height, v4l2src->v4l2object->videodev),
        GST_ERROR_SYSTEM);
    return FALSE;
  }

What is wrong here ?

a) count the number of %'s and the number of actual arguments.  Then rub your
eyes and count them again.

b) Please, *imagine* you get this error message as a user.  *a user*.  This is
not a debugging message, this should be a readable message.  It should not
contain @, x, and stuff like that.  It should not contain a word like
pixelformat.  What is a pixelformat ? All that stuff needs to go in a debug
string.  Does the width and height matter in this case ? Please explain in
human terms what the problem is.

There are more like these:
    GST_ELEMENT_ERROR (v4l2src, RESOURCE, READ,
        (_("Could not mmap video buffer %d."), n), GST_ERROR_SYSTEM);

What is mmap ? Why does it matter *which* value of n it failed for ? All of
that -> debug info.

Really, *read* the error messages that will get shown and think about them in
the perspective of the application.  It is not that hard, it just requires
putting yourself in that position.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email