[gstreamer-bugs] [Bug 338818] [PLUGIN-MOVE] v4l2src from bad to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=338818

  GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #31 from Tim-Philipp Müller  2006-10-03 15:10 UTC -------
> I added a G_GNUC_PRINTF in core, and now the wrong number of arguments 
> gets caught properly.  Too bad I can't actually commit it, because it
> doesn't understand things like GST_PTR_FORMAT :/

Why not have two declarations, one without G_GNUC_PRINTF (if
HAVE_PRINTF_EXTENSION is set) and one with G_GNUC_PRINTF (when GST_PTR_FORMAT
and GST_SEGMENT_FORMAT just map to "p" anyway)? That way mistakes like this
would at least be caught by folks building on/for platforms where the printf
extension is disabled or unavailable. We could even wrap this into a
GST_GNUC_PRINTF, since the same ussye exists with the log functions IIRC.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email