[gstreamer-bugs] [Bug 357432] [libs] GstController needs to keep controlled objects alive

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=357432

  GStreamer | gstreamer (core) | Ver: HEAD CVS


René Stadler changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73308|0                           |1
        is obsolete|                            |




------- Comment #2 from René Stadler  2006-10-05 17:37 UTC -------
Created an attachment (id=74068)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=74068&action=view)
Updated, more complete fix.

Updated patch that applies cleanly again and does not collide with recent
changes.

Be more elegant by just writing self->object = g_object_ref (object) to obtain
the reference.  Now that the controller properly references its controlled
object, it becomes more important to properly free resources: Moved most
cleanup from the finalize to the newly added dispose handler.  Functions don't
need an extra guard check to determine if dispose has been run because they all
end up locking the mutex (which is still freed in finalize) and then try to
find a property on the list (which is set to NULL in dispose, along with
releasing the controlled object reference).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email