[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348085

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #9 from René Stadler  2006-10-05 18:18 UTC -------
About the sink vs. passthrough transform elements: This is a general question,
and it should not make any difference in theory.  That is, you can easily turn
a passthrough filter into a sink by linking a fakesink to the srcpad.  The
other way around: You can easily turn any sink into a passthrough filter by
linking a tee element before, although I think this can have side-effects due
to limitations in tee (which may partly be unsolvalbe? don't know).  Because
buffer data is immutable in gstreamer, this is equally efficient at least since
the tee element does not copy any data (you know that of course, I just want to
mention it generally).

I was under the assumption that analyzers generally make the most sense to be
implemented as passthrough filters (like level).  The only exception I see is
goom, which is rather a sink for audio and a source for video.  Thinking more
about it, people should usually link analyzers into their pipelines by using
"tee ! audioconvert ! audioresample ! analyzer ! fakesink".

About the data format of the message: I was actually about to propose to change
to a more format agnostic layout, that is, it should output the dB result
values rather in gdouble.  Stefan mentioned on IRC that the element might
optionally get a more accurate analysis capability by using a library in the
future.  Will be far more easy to not have any applications using this have to
change the message parsing.  The fact that spectrum currently just outputs
integer dB values should not matter, it's detail that can change in the future.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email