[gstreamer-bugs] [Bug 348085] [PLUGIN-MOVE] move spectrum to good

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348085

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #11 from Stefan Kost (gstreamer, gtkdoc dev)  2006-10-06 02:36 UTC -------
2006-10-06  Stefan Kost  <ensonic at users.sf.net>

        * gst/spectrum/gstspectrum.c: (gst_spectrum_init),
        (gst_spectrum_transform_ip):
          Removed cruft code that was just commented out. Removed some obsolete
          debug logs statements.

tim, thanks for the review. I did some more cleanups. I could not find the
mentioned GST_LOG ("               hello") statement.

Regarding the sink. IMHO its easier to just link a bunch of different analysers
than to use a tee and have them in parallel (more memcopies). The chain gets
terminated using a fakesink.

Rene also commented on the current way of returning results. Returning a
GstBuffer sounds quite freeform to me (like a db blob), but has the advantage
of having less overhead. need to think about this.

Finally, I am quite sure the event handling (gst_spectrum_event()) is right. If
not it done wrong all over the place in gst. Are we talking about the same
thing?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email