[gstreamer-bugs] [Bug 342564] Configure options causing compilation to fail

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Fri Oct 13 01:31:35 PDT 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=342564

  GStreamer | gstreamer (core) | Ver: 0.10.x





------- Comment #15 from Stefan Kost (gstreamer, gtkdoc dev)  2006-10-13 08:30 UTC -------
what is the idea behind using dummy #defines instead of making the api
unavailable. Personally I want my build to fail if API is not available. Then I
can add configure checks that require gstreamer to be build with the feature I
actually use in my app. if we have the defines in place, it goes unnoticed that
the API does not work.

What about just ifdef'ing the functionbody in the .c file:

GstElement*
gst_parse_launchv(const gchar **argv, GError **error)
{
#ifndef GST_DISABLE_PARSE
  ...
  original code
  ...
#else
  GST_WARNING ("disabled API called");
  return NULL;
#endif
}

This way we reduce code size and keep ABI intact. Although I would prefer the
current solution, if parse is disabled I don't want to have that ABI part in
the resulting lib.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email




More information about the Gstreamer-bugs mailing list