[gstreamer-bugs] [Bug 363607] New: xvimagesink xwindow_draw_border() slowness

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=363607

  GStreamer | gst-plugins-base | Ver: HEAD CVS

           Summary: xvimagesink xwindow_draw_border() slowness
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


if one sets xvimagesink->keep_aspect=TRUE xvimagsink centers the picture in
gst_xvimagesink_xvimage_put(). A few lines down it calls
gst_xvimagesink_xwindow_draw_borders(). This is causing quite a slowdown in
performance for us (just commenting out the _xwindow_draw_borders() call make
it much better).

Now the plan is:
* first only call _xwindow_draw_borders() if xvimagesink->keep_aspect==TRUE,
otherwise there will be no border anyway.
* next only do the centering and the border-drawing if the sizes have changed.

Finally I belive its up to the ui to paint the background black (or to what
ever). So wouldn't it make sense to have a 'draw-border' property (default
TRUE), so that if apps handle the sizing, they can paint the border?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email